Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754143AbdGNMKp (ORCPT ); Fri, 14 Jul 2017 08:10:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46286 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051AbdGNMKm (ORCPT ); Fri, 14 Jul 2017 08:10:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 96A6B80480 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 96A6B80480 Message-ID: <1500033668.28252.14.camel@redhat.com> Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation From: Gerd Hoffmann To: Kirti Wankhede , "Zhang, Tina" , "Tian, Kevin" , "linux-kernel@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "alex.williamson@redhat.com" , "zhenyuw@linux.intel.com" , "chris@chris-wilson.co.uk" , "Lv, Zhiyuan" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" Date: Fri, 14 Jul 2017 14:01:08 +0200 In-Reply-To: References: <1499293795-6265-1-git-send-email-tina.zhang@intel.com> <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com> <1499753648.8257.3.camel@redhat.com> <20170711091236.run4zirxmr34kazb@phenom.ffwll.local> <237F54289DF84E4997F34151298ABEBC7C57BF86@SHSMSX101.ccr.corp.intel.com> <20170712074038.izr6ureby4vwtq27@phenom.ffwll.local> <1500026519.28252.7.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 14 Jul 2017 12:10:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 30 On Fri, 2017-07-14 at 15:45 +0530, Kirti Wankhede wrote: > > On 7/14/2017 3:31 PM, Gerd Hoffmann wrote: > >   Hi, > > > > > In case when VFIO region is used to provide surface to QEMU, > > > plane_id > > > would be region index, > > > > Then we should name it "region_index" not "plane_id". > > > > > for example region 10 could be used for primary > > > surface and region 11 could be used for cursor surface. So in > > > that > > > case, > > > mdev vendor driver should return plane_type and its corresponding > > > plane_id. > > > > Hmm?  plane_type is the input (userspace -> kernel) parameter. > > > > Yes, that's right. Sorry for confusion. And mdev vendor driver would > return which region to read. Ok, so the plan for supporting multiple planes is to have a separate vfio region for each? Ok, we should add region_index to the struct then. cheers, Gerd