Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754223AbdGNMMF (ORCPT ); Fri, 14 Jul 2017 08:12:05 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:51173 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751392AbdGNMMC (ORCPT ); Fri, 14 Jul 2017 08:12:02 -0400 From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Sunil Goutham , Robert Richter Cc: Greg Kroah-Hartman , Linus Torvalds , Guenter Roeck , akpm@linux-foundation.org, netdev@vger.kernel.org, "David S . Miller" , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, x86@kernel.org, Arnd Bergmann , Thanneeru Srinivasulu , George Cherian , Vadim Lomovtsev , Radha Mohan Chintakuntla , linux-arm-kernel@lists.infradead.org Subject: [PATCH 11/22] net: thunder_bgx: avoid format string overflow warning Date: Fri, 14 Jul 2017 14:07:03 +0200 Message-Id: <20170714120720.906842-12-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170714120720.906842-1-arnd@arndb.de> References: <20170714120720.906842-1-arnd@arndb.de> X-Provags-ID: V03:K0:IXkVdlkrGd4gRR1l004nsDZDHsJCZogj8lLqo+ket4PT6i6j4So ZrlGb0Lr7KjpTnAvHSl3UvfR89sScvb8u8sfyrOCckH9h6m5pNvnncQOQ22udefMgXWXYLq B9htEtP8y6kI3GVn9qnXa/YfSDBviYY+azRwOaEQdEYnhhvf+5CFwWY0FWurl8Woe/sf1hd GPimPSFvBH2YKGR+Ta/HQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:xI/tuusgwSs=:HZEowIDYy7v5MokrN/z9d4 +fflzhBCSBCtiZ872Qoio+eraYz5hNSszhppDpNKndvmZXHkHyPnEF4zKkVr4jDWSkPFnjbBs 3nHfbUa2JhGW/wA42qEWX5ph97iwtzXy3fx7bbl+xVnVdVpg8m1jg0P0wVdRu8w9p6mHGK/zb hceCjGMHXJ5VJM5pLtF1B6KX/sTVHh/VG5RoKm+TI6Q51WcnA9uS+GfaDDmptgTrq2ASq8twd FSokNWOU38U9elPUuH02Tp8R6l9fTct96obJTPGrm64T6uIVQ3fdWsxd5ymkH+dT4ZULnLtBM DS3FaveCRlv7YFtXE+4Gy8qBzsK+S3A97/qr5VASnaKX9pY5kPvt01yQNLWd8t9S7YkGG1hho anuloYgQiEhZVosCzSP1EtKON9jZq+Dj10SmXEcNovGJZeP3ROd1UrAra5iyc+dHyrQqwAtWv VcBk+h09NcI4d4EYdjwcdlapleCkl3ulVxVHQC4tbbSKH/Ktz7DYa3iJIHR8mLXHl/IM9wLo8 pENknVXsfrc1KGoE6s6INnfldtc+fxFUdpv1qUYZRQBVpbt0TK60UEkjrFf3zupuWp0F18PbB OvdrBzAKkNPSX3v4jmK99aO86dHvaBsaKxf2KGHobdxCiLcdFcXSkVR1y5F+xLCMY9v79lYUr SdfZJTnNcQI0+xZkRn4d/UYf1fVeJI4SLCOwrn0tAv6bz5jT71/9EAWYA8azHsWRMKWuPo6UW Gf0GFi3n8nUP5Kc+bscabBYF84FaIkgN7fhvzg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 32 gcc warns that the temporary buffer might be too small here: drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_probe': drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: error: '%d' directive writing between 1 and 10 bytes into a region of size between 9 and 11 [-Werror=format-overflow=] sprintf(str, "BGX%d LMAC%d mode", bgx->bgx_id, lmacid); ^~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: note: directive argument in the range [0, 2147483647] drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:3: note: 'sprintf' output between 16 and 27 bytes into a destination of size 20 This probably can't happen, but it can't hurt to make it long enough for the theoretical limit. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index a0ca68ce3fbb..79112563a25a 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -1008,7 +1008,7 @@ static void bgx_print_qlm_mode(struct bgx *bgx, u8 lmacid) { struct device *dev = &bgx->pdev->dev; struct lmac *lmac; - char str[20]; + char str[27]; if (!bgx->is_dlm && lmacid) return; -- 2.9.0