Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754152AbdGNN6O (ORCPT ); Fri, 14 Jul 2017 09:58:14 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:32362 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753634AbdGNN6L (ORCPT ); Fri, 14 Jul 2017 09:58:11 -0400 Subject: Re: [PATCH 1/2] printk: Unconditionally unregister boot consoles if in init section To: Petr Mladek References: <1499337481-19397-1-git-send-email-matt.redfearn@imgtec.com> <20170707044537.GB7478@jagdpanzerIV.localdomain> <0212d098-e307-2ea1-cb41-1e81d545da56@imgtec.com> <20170711124308.GA3393@pathway.suse.cz> <86ff1193-8485-4b14-492f-627720c1d868@imgtec.com> <20170712111117.GD3393@pathway.suse.cz> <20170714124026.GA32632@pathway.suse.cz> CC: Sergey Senozhatsky , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , , Steven Rostedt , From: Matt Redfearn Message-ID: <73a13c55-367f-12c2-94c1-5e0101e74068@imgtec.com> Date: Fri, 14 Jul 2017 14:58:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170714124026.GA32632@pathway.suse.cz> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.150.130.83] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1526 Lines: 37 On 14/07/17 13:40, Petr Mladek wrote: > On Wed 2017-07-12 13:11:17, Petr Mladek wrote: >> On Tue 2017-07-11 15:41:50, Matt Redfearn wrote: >>> On 11/07/17 13:43, Petr Mladek wrote: >>>> IMHO, the reasonable solution is to move early console code and data >>>> out of the init sections. We should do this for the early consoles >>>> where the corresponding real console is registered using a deferred >>>> probe. Others should be already replaced by the real console when >>>> printk_late_init() is called. At least this is how I understand it. >>> This seems like the most reasonable way forward to me as well, >>> though sadly will lead to some post-init kernel bloat. >>> >>> I still think, however, that this patch is a reasonable change to >>> make. >> The thing is that this patch "silently" makes the keep_bootcon >> option almost unusable. > I was wrong here. I thought that most early consoles used the init > section. It was mentioned somewhere and I looked a wrong way. > But this is not true. In fact, it seems that there are > only few of them. Most early consoles have struct console > and the write() callback in the normal section that is preserved. > > Matt's patch and the keep_bootcon option makes sense to me > after all. Let me to resend Matt's patch with some small > improvements and one more patch that improves the check > of early consoles that use init section. I'll keep Matt > as the author of the first patch. Thanks for looking into this and your fix Petr! Matt > > Best Regards, > Petr >