Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754310AbdGNOQK (ORCPT ); Fri, 14 Jul 2017 10:16:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:58882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754018AbdGNOQJ (ORCPT ); Fri, 14 Jul 2017 10:16:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8278522CAF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: <20170713110413.12721-3-linux-kernel-dev@beckhoff.com> References: <20170712090408.12212-1-linux-kernel-dev@beckhoff.com> <20170713110413.12721-1-linux-kernel-dev@beckhoff.com> <20170713110413.12721-3-linux-kernel-dev@beckhoff.com> From: Rob Herring Date: Fri, 14 Jul 2017 09:15:47 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] drm/panel: simple: Add support for ddc-only panel To: linux-kernel-dev@beckhoff.com Cc: Thierry Reding , David Airlie , "open list:DRM PANEL DRIVERS" , open list , Patrick Bruenn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1708 Lines: 45 On Thu, Jul 13, 2017 at 6:04 AM, wrote: > From: Patrick Bruenn > > This is a fix for the CX9020 Embedded PC. On that device the 24-bit > parallel-display signal of the imx53 is combined with an I2C channel > and converted to DVI-D port. Devicetree magic always requires a panel > connected to the parallel-display port. Then fix this. It's not the DT that requires this, but limitations in the i.MX driver. > We add an empty panel_desc, to get recognized by the panel-simple > driver, which can then use the ddc bus to read the panels configuration. > > Signed-off-by: Patrick Bruenn > --- > drivers/gpu/drm/panel/panel-simple.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index c4566ce8fda7..52b2a7fb59ed 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1856,6 +1856,9 @@ static const struct panel_desc winstar_wf35ltiacd = { > .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > }; > > +static const struct panel_desc simple_ddc_only = { > +}; > + > static const struct of_device_id platform_of_match[] = { > { > .compatible = "ampire,am-480272h3tmqw-t01h", > @@ -2050,6 +2053,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "winstar,wf35ltiacd", > .data = &winstar_wf35ltiacd, > }, { > + .compatible = "simple,ddc-only", If you notice the rest of the file, we require compatibles be specific for the panels. What you want here is a "dvi-connector" node. Rob