Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932142AbdGNOey (ORCPT ); Fri, 14 Jul 2017 10:34:54 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:32829 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932108AbdGNOew (ORCPT ); Fri, 14 Jul 2017 10:34:52 -0400 Date: Fri, 14 Jul 2017 09:34:50 -0500 From: Rob Herring To: "Thang Q. Nguyen" Cc: Greg Kroah-Hartman , Mark Rutland , Mathias Nyman , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Phong Vo , Loc Ho , Tung Nguyen , patches@apm.com Subject: Re: [PATCH v4 1/1] usb:host:xhci support option to disable the xHCI USB2 HW LPM Message-ID: <20170714143449.hr3eajqywafl4v3r@rob-hp-laptop> References: <1499846808-25981-1-git-send-email-tqnguyen@apm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499846808-25981-1-git-send-email-tqnguyen@apm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 30 On Wed, Jul 12, 2017 at 03:06:48PM +0700, Thang Q. Nguyen wrote: > XHCI specification 1.1 does not require xHCI-compliant controllers > to always enable hardware USB2 LPM. However, the current xHCI > driver always enable it when seeing HLC=1. > This patch supports an option for users to control disabling > USB2 Hardware LPM via DT/ACPI attribute. > This option is needed in case user would like to disable this > feature. For example, their xHCI controller has its USB2 HW LPM > broken. > > Signed-off-by: Tung Nguyen > Signed-off-by: Thang Q. Nguyen > --- > Changes since v3: > - Bypass updating LPM parameters when HW LPM is optionally disabled. > Changes since v2: > - Change code to disable HW LPM as an option for user which > is set via ACPI/DT. > Changes since v1: > - Update DT/ACPI attribute and corresponding codes from HLE to LPM to > be consistent with other attribute names. > --- > Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + I acked v3. Please add acks when posting new versions. > drivers/usb/host/xhci-plat.c | 3 +++ > drivers/usb/host/xhci.c | 6 ++++++ > drivers/usb/host/xhci.h | 1 + > 4 files changed, 11 insertions(+), 0 deletions(-)