Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754511AbdGNPKg (ORCPT ); Fri, 14 Jul 2017 11:10:36 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:34049 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754178AbdGNPKf (ORCPT ); Fri, 14 Jul 2017 11:10:35 -0400 MIME-Version: 1.0 In-Reply-To: <6341f91f-1c56-2188-f55b-2f47d23262fc@mni.thm.de> References: <1499794333.5315.8.camel@gmx.de> <1499796510.5315.27.camel@gmx.de> <1499853345.23742.8.camel@gmx.de> <1499858703.23742.25.camel@gmx.de> <1500039368.5763.12.camel@gmx.de> <1500039693.5763.15.camel@gmx.de> <6341f91f-1c56-2188-f55b-2f47d23262fc@mni.thm.de> From: Karol Herbst Date: Fri, 14 Jul 2017 17:10:34 +0200 Message-ID: Subject: Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 To: Tobias Klausmann Cc: Mike Galbraith , Ilia Mirkin , Peter Zijlstra , David Airlie , "nouveau@lists.freedesktop.org" , LKML , "dri-devel@lists.freedesktop.org" , Ben Skeggs Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 55 Yeah, we shouldn't let the machine die. Are there more WARN_ON_ONCE usage we could convert to WARN_ONCE? Reviewed-By: Karol Herbst On Fri, Jul 14, 2017 at 5:05 PM, Tobias Klausmann wrote: > On 7/14/17 3:41 PM, Mike Galbraith wrote: >> >> On Fri, 2017-07-14 at 15:36 +0200, Mike Galbraith wrote: >>> >>> All DRM did was to slip a >>> WARN_ON_ONCE() that nouveau triggers into a kernel module where such >>> things no longer warn, they blow the box out of the water. >> >> BTW, turn that irksome WARN_ON_ONCE() in drivers/gpu/drm/drm_vblank.c >> into a WARN_ONCE(), and all is peachy, you get the warning, box lives. >> >> --- >> drivers/gpu/drm/drm_vblank.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> --- a/drivers/gpu/drm/drm_vblank.c >> +++ b/drivers/gpu/drm/drm_vblank.c >> @@ -605,7 +605,8 @@ bool drm_calc_vbltimestamp_from_scanoutp >> */ >> if (mode->crtc_clock == 0) { >> DRM_DEBUG("crtc %u: Noop due to uninitialized mode.\n", >> pipe); >> - WARN_ON_ONCE(drm_drv_uses_atomic_modeset(dev)); >> + WARN_ONCE(drm_drv_uses_atomic_modeset(dev), "%s: report >> me.\n", >> + dev->driver->name); >> return false; >> } > > > > Hey, > > confirmed this helps saving the box, but we still have to find the root > cause! Backtrace with the above fix applied (and the one which came in with > the latest drm-fixes merge)! > > > [1] https://hastebin.com/uyoqifijed.http > > Thanks, > > Tobias >Reviewed-By: Karol Herbst > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau