Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754552AbdGNPOv (ORCPT ); Fri, 14 Jul 2017 11:14:51 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51688 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754031AbdGNPOu (ORCPT ); Fri, 14 Jul 2017 11:14:50 -0400 Date: Fri, 14 Jul 2017 16:14:39 +0100 From: Mark Brown To: Sean Wang Cc: mark.rutland@arm.com, jamesjj.liao@mediatek.com, devicetree@vger.kernel.org, chenglin.xu@mediatek.com, lgirdwood@gmail.com, henryc.chen@mediatek.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, chen.zhong@mediatek.com Message-ID: <20170714151439.qospwvlxaoo3yauc@sirena.org.uk> References: <4276ab23ae0bbb6a54b1add98c4dc668f1a69c50.1496425268.git.sean.wang@mediatek.com> <20170606182224.sifkfod7hehadjvm@sirena.org.uk> <1498233365.20651.25.camel@mtkswgap22> <20170623161420.tbhn6sjuz7jjhaiu@sirena.org.uk> <1498236198.20651.32.camel@mtkswgap22> <1500044768.16278.37.camel@mtkswgap22> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hp2a3qguigil3cxm" Content-Disposition: inline In-Reply-To: <1500044768.16278.37.camel@mtkswgap22> X-Cookie: My mind is a potato field ... User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/9] regulator: mt6380: Add support for MT6380 X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 32 --hp2a3qguigil3cxm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 14, 2017 at 11:06:08PM +0800, Sean Wang wrote: > We usually want to use /sys/class/regulator/regulator.*/status to get > actual status from hardware, but if we remove the get_status(), the > status entry under sysfs would be gone. So could I keep the get_status > callback in this driver ? If the device doesn't support physical status readback it shouldn't have a get_status() callback. =20 --hp2a3qguigil3cxm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAllo398ACgkQJNaLcl1U h9Cergf/eMKkWqaydtM212fyr2PcAvhOq989RGyuQ00UtwejpIYDwvxsT7nO3ksH EeTd2xDBJEcWYQlBTMQcDlu7xsb49PoYYKSddY5aadBWRLf5eClEj5LJVhH0Arcq cOMjj5w/rmgoByD0QfSAVW1gzESLK1n9ubJDYwgehqApt50W3xbcPuGlVTSNV7Y2 YUYCSxDn+KpwcTG6tcvV4vyvEahtc2Cttg8ZFEycFxKusC4XQN+XpTn612XDW7SF Lvs76KGgBQUoUTr6n60z5jE860URTmY/75h1dl/oqgAJ3O9dRvaCN3h6usFF99OJ jXaMz2I+PaZj2FTADb1tmZJIw5ouXw== =FWnv -----END PGP SIGNATURE----- --hp2a3qguigil3cxm--