Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754605AbdGNPUE (ORCPT ); Fri, 14 Jul 2017 11:20:04 -0400 Received: from mail-qt0-f173.google.com ([209.85.216.173]:35899 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754177AbdGNPUC (ORCPT ); Fri, 14 Jul 2017 11:20:02 -0400 MIME-Version: 1.0 In-Reply-To: <31d327dd-bc3d-cb80-45a9-6a8eb9eb2a9d@mni.thm.de> References: <1499794333.5315.8.camel@gmx.de> <1499796510.5315.27.camel@gmx.de> <1499853345.23742.8.camel@gmx.de> <1499858703.23742.25.camel@gmx.de> <1500039368.5763.12.camel@gmx.de> <1500039693.5763.15.camel@gmx.de> <6341f91f-1c56-2188-f55b-2f47d23262fc@mni.thm.de> <31d327dd-bc3d-cb80-45a9-6a8eb9eb2a9d@mni.thm.de> From: Ilia Mirkin Date: Fri, 14 Jul 2017 11:20:01 -0400 X-Google-Sender-Auth: 9TcCsKQScO_8nIfxjrtphZszuJk Message-ID: Subject: Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 To: Tobias Klausmann Cc: Karol Herbst , Mike Galbraith , Peter Zijlstra , David Airlie , "nouveau@lists.freedesktop.org" , LKML , "dri-devel@lists.freedesktop.org" , Ben Skeggs Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 437 Lines: 12 On Fri, Jul 14, 2017 at 11:19 AM, Tobias Klausmann wrote: > The conversion is a nice catch, but i'd like to have a bit more context, see > below! > > With a better description: > > Tobias Klausmann I don't think it was meant as a serious patch. WARN_ON_ONCE should work. The fix isn't to remove all instances of WARN_ON_ONCE. The fix is to fix WARN_ON_ONCE.