Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754269AbdGNP4E (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Jul 2017 11:56:04 -0400
Received: from merlin.infradead.org ([205.233.59.134]:37722 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753382AbdGNP4D (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jul 2017 11:56:03 -0400
Date: Fri, 14 Jul 2017 17:55:41 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>,
        Karol Herbst <karolherbst@gmail.com>, Mike Galbraith <efault@gmx.de>,
        David Airlie <airlied@linux.ie>,
        "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM:
 exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335
Message-ID: <20170714155541.onocqn5o4f7v2mlh@hirez.programming.kicks-ass.net>
References: <CAKb7UvgOOzVj=tygh4-BDRXGFUr2Y8U0pkV+-oYjy6EVYsQ+hg@mail.gmail.com>
 <1499853345.23742.8.camel@gmx.de>
 <1499858703.23742.25.camel@gmx.de>
 <CAKb7UvhMzbMKFMFP1UvbrTC0Un4F2u5_mv5VWrkizRxo_AbN4g@mail.gmail.com>
 <1500039368.5763.12.camel@gmx.de>
 <1500039693.5763.15.camel@gmx.de>
 <6341f91f-1c56-2188-f55b-2f47d23262fc@mni.thm.de>
 <CAEXux-b=u88Bu6JN3xbP+=Fwq2rPRXTXdNWJpBu+pSdsNYwQRQ@mail.gmail.com>
 <31d327dd-bc3d-cb80-45a9-6a8eb9eb2a9d@mni.thm.de>
 <CAKb7UvhtOBOcOcsZXXXa2qVDd6YWQaZrKtMwfPj5V8wk=97DXw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKb7UvhtOBOcOcsZXXXa2qVDd6YWQaZrKtMwfPj5V8wk=97DXw@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 597
Lines: 16

On Fri, Jul 14, 2017 at 11:20:01AM -0400, Ilia Mirkin wrote:
> On Fri, Jul 14, 2017 at 11:19 AM, Tobias Klausmann
> <tobias.johannes.klausmann@mni.thm.de> wrote:
> > The conversion is a nice catch, but i'd like to have a bit more context, see
> > below!
> >
> > With a better description:
> >
> > Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
> 
> I don't think it was meant as a serious patch. WARN_ON_ONCE should
> work. The fix isn't to remove all instances of WARN_ON_ONCE. The fix
> is to fix WARN_ON_ONCE.

Quite so. Clearly I buggered it for modules; that really wasn't the
plan.