Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751156AbdGNSU1 (ORCPT ); Fri, 14 Jul 2017 14:20:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47462 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbdGNSUZ (ORCPT ); Fri, 14 Jul 2017 14:20:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6B06B611A6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 14 Jul 2017 11:20:23 -0700 From: Stephen Boyd To: Kiran Gunda Cc: gregkh@linuxfoundation.org, Abhijeet Dharmapurikar , Christophe JAILLET , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V2 2/5] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other code cleanup Message-ID: <20170714182016.GJ22780@codeaurora.org> References: <1499690549-30765-1-git-send-email-kgunda@codeaurora.org> <1499690549-30765-3-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499690549-30765-3-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1964 Lines: 63 On 07/10, Kiran Gunda wrote: > > -static u16 pmic_arb_find_apid(struct spmi_pmic_arb *pa, u16 ppid) > +static u16 pmic_arb_find_apid(struct spmi_pmic_arb *pmic_arb, u16 ppid) > { > + struct apid_data *apid_info = &pmic_arb->apid_data[pmic_arb->last_apid]; > u32 regval, offset; > - u16 apid; > - u16 id; > + u16 id, i; > > /* > - * PMIC_ARB_REG_CHNL is a table in HW mapping channel to ppid. > + * PMIC_ARB_REG_APID is a table in HW mapping apid to ppid. > * ppid_to_apid is an in-memory invert of that table. > */ > - for (apid = pa->last_apid; ; apid++) { > - offset = PMIC_ARB_REG_CHNL(apid); > - if (offset >= pa->core_size) > + for (i = pmic_arb->last_apid; ; i++, apid_info++) { Can we keep apid instead of replacing it with i please? That will reduce the noise in this function. > + offset = PMIC_ARB_REG_CHNL(i); > + if (offset >= pmic_arb->core_size) > break; > > - regval = readl_relaxed(pa->cnfg + > - SPMI_OWNERSHIP_TABLE_REG(apid)); > - pa->apid_data[apid].owner = SPMI_OWNERSHIP_PERIPH2OWNER(regval); > + regval = readl_relaxed(pmic_arb->cnfg + > + SPMI_OWNERSHIP_TABLE_REG(i)); > + apid_info->owner = SPMI_OWNERSHIP_PERIPH2OWNER(regval); > > - regval = readl_relaxed(pa->core + offset); > + regval = readl_relaxed(pmic_arb->core + offset); > if (!regval) > continue; > > id = (regval >> 8) & PMIC_ARB_PPID_MASK; > - pa->ppid_to_apid[id] = apid | PMIC_ARB_CHAN_VALID; > - pa->apid_data[apid].ppid = id; > + pmic_arb->ppid_to_apid[id] = i | PMIC_ARB_APID_VALID; > + apid_info->ppid = id; > if (id == ppid) { > - apid |= PMIC_ARB_CHAN_VALID; > + i |= PMIC_ARB_APID_VALID; > break; > } > } > - pa->last_apid = apid & ~PMIC_ARB_CHAN_VALID; > + pmic_arb->last_apid = i & ~PMIC_ARB_APID_VALID; > > - return apid; > + return i; > } Otherwise patch looks ok. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project