Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751373AbdGOBry (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Jul 2017 21:47:54 -0400
Received: from mailgw01.mediatek.com ([210.61.82.183]:22698 "EHLO
        mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1751121AbdGOBrw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jul 2017 21:47:52 -0400
Message-ID: <1500083261.16278.40.camel@mtkswgap22>
Subject: Re: [PATCH net-next 2/4] net-next: mediatek: add platform data to
 adapt into various hardware
From: Sean Wang <sean.wang@mediatek.com>
To: Andrew Lunn <andrew@lunn.ch>
CC: <john@phrozen.org>, <davem@davemloft.net>, <nbd@openwrt.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>
Date: Sat, 15 Jul 2017 09:47:41 +0800
In-Reply-To: <20170712145050.GD2557@lunn.ch>
References: <cover.1499829241.git.sean.wang@mediatek.com>
         <401e9fa04ea4759c936fa5af11bb2b5c97ef14f0.1499829241.git.sean.wang@mediatek.com>
         <20170712145050.GD2557@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1255
Lines: 61

On Wed, 2017-07-12 at 16:50 +0200, Andrew Lunn wrote:
> > +static int mtk_clk_enable(struct mtk_eth *eth)
> > +{
> > +	int clk, ret;
> > +
> > +	for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
> > +		if (eth->clks[clk]) {
> > +			ret = clk_prepare_enable(eth->clks[clk]);
> > +			if (ret)
> > +				goto err_disable_clks;
> > +		}
> > +	}
> > +
> > +	return 0;
> > +
> > +err_disable_clks:
> > +	while (--clk >= 0) {
> > +		if (eth->clks[clk])
> > +			clk_disable_unprepare(eth->clks[clk]);
> > +	}
> > +
> > +	return ret;
> > +}
> 
> > +
> >  static int mtk_hw_init(struct mtk_eth *eth)
> >  {
> >  	int i, val;
> > @@ -1847,10 +1881,8 @@ static int mtk_hw_init(struct mtk_eth *eth)
> >  	pm_runtime_enable(eth->dev);
> >  	pm_runtime_get_sync(eth->dev);
> >  
> > -	clk_prepare_enable(eth->clks[MTK_CLK_ETHIF]);
> > -	clk_prepare_enable(eth->clks[MTK_CLK_ESW]);
> > -	clk_prepare_enable(eth->clks[MTK_CLK_GP1]);
> > -	clk_prepare_enable(eth->clks[MTK_CLK_GP2]);
> > +	mtk_clk_enable(eth);
> > +
> 
> mtk_clk_enable() returns an error code. It is probably a good idea to
> use it, especially if it could be EPRODE_DEFER.

okay, I will improve those clocks handling better along with Florian's
suggestion in the next version

	Sean












> 
>     Andrew