Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751174AbdGODM0 (ORCPT ); Fri, 14 Jul 2017 23:12:26 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:33254 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbdGODMY (ORCPT ); Fri, 14 Jul 2017 23:12:24 -0400 From: Brian Norris To: Sean Paul , David Airlie , Daniel Vetter , Jani Nikula Cc: , dri-devel@lists.freedesktop.org, Brian Norris Subject: [PATCH] drm/vgem: add compat_ioctl support Date: Fri, 14 Jul 2017 20:12:12 -0700 Message-Id: <20170715031212.108695-1-briannorris@chromium.org> X-Mailer: git-send-email 2.13.2.932.g7449e964c-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 23 DRM drivers should supply a compat version if they're going to provide an ioctl implementation at all. This can confuse 32-bit user space on a 64-bit system. Signed-off-by: Brian Norris --- drivers/gpu/drm/vgem/vgem_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 9fee38a942c4..3835656e2baf 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -220,6 +220,7 @@ static const struct file_operations vgem_driver_fops = { .poll = drm_poll, .read = drm_read, .unlocked_ioctl = drm_ioctl, + .compat_ioctl = drm_compat_ioctl, .release = drm_release, }; -- 2.13.2.932.g7449e964c-goog