Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751187AbdGOEiO (ORCPT ); Sat, 15 Jul 2017 00:38:14 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:34710 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbdGOEiM (ORCPT ); Sat, 15 Jul 2017 00:38:12 -0400 MIME-Version: 1.0 In-Reply-To: <20170628222937.jscrixi5uo2vasnk@rob-hp-laptop> References: <1498488802-1439-1-git-send-email-jacob-chen@iotwrt.com> <20170628222937.jscrixi5uo2vasnk@rob-hp-laptop> From: Jacob Chen Date: Sat, 15 Jul 2017 12:38:11 +0800 Message-ID: Subject: Re: [PATCH 5/5] dt-bindings: Document the Rockchip RGA bindings To: Rob Herring Cc: linux-kernel@vger.kernel.org, "open list:ARM/Rockchip SoC..." , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Heiko Stuebner , Yakir Yang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2590 Lines: 74 Hi rob, 2017-06-29 6:29 GMT+08:00 Rob Herring : > On Mon, Jun 26, 2017 at 10:53:22PM +0800, Jacob Chen wrote: >> Add DT bindings documentation for Rockchip RGA >> >> Signed-off-by: Yakir Yang >> Signed-off-by: Jacob Chen >> --- >> .../devicetree/bindings/media/rockchip-rga.txt | 36 ++++++++++++++++++++++ > > Should be under bindings/gpu/ > >> 1 file changed, 36 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/rockchip-rga.txt >> >> diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.txt b/Documentation/devicetree/bindings/media/rockchip-rga.txt >> new file mode 100644 >> index 0000000..48a260e5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/rockchip-rga.txt >> @@ -0,0 +1,36 @@ >> +device-tree bindings for rockchip 2D raster graphic acceleration controller (RGA) >> + >> +RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D >> +graphics operations, such as point/line drawing, image scaling, rotation, >> +BitBLT, alpha blending and image blur/sharpness. >> + >> +Required properties: >> +- compatible: value should be one of the following >> + "rockchip,rk3228-rga"; >> + "rockchip,rk3288-rga"; >> + "rockchip,rk3399-rga"; >> + >> +- interrupts: RGA interrupt number. >> + >> +- clocks: phandle to RGA sclk/hclk/aclk clocks >> + >> +- clock-names: should be "aclk" "hclk" and "sclk" >> + >> +- resets: Must contain an entry for each entry in reset-names. >> + See ../reset/reset.txt for details. >> +- reset-names: should be "core" "axi" and "ahb" >> + >> +Example: >> +SoC specific DT entry: >> + rga: rga@ff680000 { > > gpu@... > It's used for v4l2 drvier, should i move it bindings/gpu/? >> + compatible = "rockchip,rk3399-rga"; >> + reg = <0xff680000 0x10000>; >> + interrupts = ; >> + interrupt-names = "rga"; >> + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE>; >> + clock-names = "aclk", "hclk", "sclk"; >> + >> + resets = <&cru SRST_RGA_CORE>, <&cru SRST_A_RGA>, <&cru SRST_H_RGA>; >> + reset-names = "core, "axi", "ahb"; >> + status = "disabled"; > > Don't show status in examples. > >> + }; >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html