Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751244AbdGOEi6 (ORCPT ); Sat, 15 Jul 2017 00:38:58 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34073 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbdGOEi5 (ORCPT ); Sat, 15 Jul 2017 00:38:57 -0400 From: Arvind Yadav To: stefanr@s5r6.in-berlin.de, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] firewire: nosy: constify pci_device_id. Date: Sat, 15 Jul 2017 10:08:46 +0530 Message-Id: <32fb3e28619694b47823518e005850d4e027846f.1500093348.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 32 pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 5796 389 0 6185 1829 drivers/firewire/nosy.o File size After adding 'const': text data bss dec hex filename 5860 325 0 6185 1829 drivers/firewire/nosy.o Signed-off-by: Arvind Yadav --- drivers/firewire/nosy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c index 180f0a9..d16a9dc9 100644 --- a/drivers/firewire/nosy.c +++ b/drivers/firewire/nosy.c @@ -694,7 +694,7 @@ add_card(struct pci_dev *dev, const struct pci_device_id *unused) return ret; } -static struct pci_device_id pci_table[] = { +static const struct pci_device_id pci_table[] = { { .vendor = PCI_VENDOR_ID_TI, .device = PCI_DEVICE_ID_TI_PCILYNX, -- 2.7.4