Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751181AbdGOHZe (ORCPT ); Sat, 15 Jul 2017 03:25:34 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33918 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbdGOHZd (ORCPT ); Sat, 15 Jul 2017 03:25:33 -0400 From: Arvind Yadav To: airlied@linux.ie, linux-kernel@vger.kernel.org, z.liuxinliang@hisilicon.com, zourongrong@gmail.com, puck.chen@hisilicon.com, kong.kongxinwei@hisilicon.com Cc: dri-devel@lists.freedesktop.org Subject: [PATCH 5/5] drm: hisilicon: constify pci_device_id. Date: Sat, 15 Jul 2017 12:55:20 +0530 Message-Id: <1500103521-23618-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 34 pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 2704 808 0 3512 db8 gpu/drm/hisilicon/hibmc/hibmc_drm_drv.o File size After adding 'const': text data bss dec hex filename 2768 744 0 3512 db8 gpu/drm/hisilicon/hibmc/hibmc_drm_drv.o Signed-off-by: Arvind Yadav --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index 2ffdbf9..a8c8186 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -401,7 +401,7 @@ static void hibmc_pci_remove(struct pci_dev *pdev) drm_dev_unref(dev); } -static struct pci_device_id hibmc_pci_table[] = { +static const struct pci_device_id hibmc_pci_table[] = { {0x19e5, 0x1711, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, {0,} }; -- 2.7.4