Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751216AbdGOLQf (ORCPT ); Sat, 15 Jul 2017 07:16:35 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:34689 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbdGOLQd (ORCPT ); Sat, 15 Jul 2017 07:16:33 -0400 MIME-Version: 1.0 In-Reply-To: <20170714132620.GA8905@kroah.com> References: <20170713153957.515045341@linuxfoundation.org> <5967e121.9fb6df0a.979fe.f2ca@mx.google.com> <20170714095120.GB2269@kroah.com> <20170714132620.GA8905@kroah.com> From: Geert Uytterhoeven Date: Sat, 15 Jul 2017 13:16:31 +0200 X-Google-Sender-Auth: Pr1LDyj8KhFN6buuV6sjHzY94Sw Message-ID: Subject: Re: [PATCH 4.4 00/57] 4.4.77-stable review To: Greg Kroah-Hartman Cc: Arnd Bergmann , "kernelci.org bot" , Linux Kernel Mailing List , Linus Torvalds , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , "# 3.4.x" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3316 Lines: 82 Hi Greg, On Fri, Jul 14, 2017 at 3:26 PM, Greg Kroah-Hartman wrote: > On Fri, Jul 14, 2017 at 02:21:10PM +0200, Arnd Bergmann wrote: >> On Fri, Jul 14, 2017 at 11:51 AM, Greg Kroah-Hartman >> wrote: >> > On Thu, Jul 13, 2017 at 02:07:45PM -0700, kernelci.org bot wrote: >> >> stable-rc/linux-4.4.y boot: 99 boots: 1 failed, 92 passed with 5 offline, 1 conflict (v4.4.76-58-g1a12e8e8a429) >> > >> > Any idea how 0-day and Guenter's system found problems with this >> > release, but you all didn't? Do you not have any SH systems in >> > kernelci? >> >> kernelci does not do any SH builds, but it did catch this driver in Despite the sh-pfc name (from legacy "shmobile"), this is a pinctrl driver for an ARM SoC. >> the allmodconfig >> builds and a couple of ARM builds that use the same one, see the mail with >> subject "stable-rc/linux-4.4.y build: 199 builds: 10 failed, 189 >> passed, 30 errors, >> 4 warnings (v4.4.76-58-g1a12e8e8a429)": >> >> Errors summary: >> >> 10 drivers/pinctrl/sh-pfc/pfc-r8a7791.c:1096:2: error: implicit >> declaration of function 'PINMUX_IPSR_GPSR' >> [-Werror=implicit-function-declaration] >> 10 drivers/pinctrl/sh-pfc/pfc-r8a7791.c:1096:28: error: >> 'DVC_MUTE' undeclared here (not in a function) >> 10 drivers/pinctrl/sh-pfc/pfc-r8a7791.c:1096:19: error: >> 'IP6_2_0' undeclared here (not in a function) > > Where is that email? I never got that, I only got this email > response... BTW, both you and I should have received the following email from kbuild test robot : [linux-stable-rc:linux-4.4.y 4899/4940] drivers/pinctrl/sh-pfc/pfc-r8a7791.c:1096:2: error: implicit declaration of function 'PINMUX_IPSR_GPSR' Unfortunately I had a day off, so I couldn't reply in time that that commit depends on commit e01678e35f4be547 ("pinctrl: sh-pfc: Rename PINMUX_IPSR_DATA() to PINMUX_IPSR_GPSR()"). As that one is a bit heavy to backport, an alternative way to backport 3908632fb829d733 ("pinctrl: sh-pfc: r8a7791: Add missing DVC_MUTE signal") is this (gmail-webinterface-whitespace-damaged) diff: diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c index 3d0490392adb7fb2..3d9e36ebcc6c6913 100644 --- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c @@ -1093,7 +1093,7 @@ static const u16 pinmux_data[] = { PINMUX_IPSR_MSEL(IP6_2_0, STP_OPWM_0_B, SEL_SSP_1), PINMUX_IPSR_MSEL(IP6_2_0, MSIOF1_SCK_B, SEL_SOF1_1), PINMUX_IPSR_MSEL(IP6_2_0, SCIF_CLK, SEL_SCIF_0), - PINMUX_IPSR_GPSR(IP6_2_0, DVC_MUTE), + PINMUX_IPSR_DATA(IP6_2_0, DVC_MUTE), PINMUX_IPSR_MSEL(IP6_2_0, BPFCLK_E, SEL_FM_4), PINMUX_IPSR_DATA(IP6_5_3, AUDIO_CLKC), PINMUX_IPSR_MSEL(IP6_5_3, SCIFB0_SCK_C, SEL_SCIFB_2), However, as probably nobody uses the DVC_MUTE signal, dropping its backporting should be OK, too. Sorry for the fuzz... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds