Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbdGOMgz (ORCPT ); Sat, 15 Jul 2017 08:36:55 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:36511 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbdGOMgy (ORCPT ); Sat, 15 Jul 2017 08:36:54 -0400 MIME-Version: 1.0 In-Reply-To: <1500115014-3420-1-git-send-email-vichy.kuo@gmail.com> References: <1500115014-3420-1-git-send-email-vichy.kuo@gmail.com> From: Andy Shevchenko Date: Sat, 15 Jul 2017 15:36:53 +0300 Message-ID: Subject: Re: [PATCH] printk: modify console_unlock with printk-safe macros To: Pierre Kuo Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , "linux-kernel@vger.kernel.org" , Joe Perches Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 532 Lines: 18 On Sat, Jul 15, 2017 at 1:36 PM, Pierre Kuo wrote: > In commit de6fcbdb68b2 ("printk: convert the rest to printk-safe"), we > create 4 helper macros to make printk-safe usage easier. > Here we modify some part of console_unlock with above marcros. > raw_spin_lock(&logbuf_lock); ...and now we have "orphaned" call to lock. > - raw_spin_unlock(&logbuf_lock); > + logbuf_unlock_irqrestore(flags); Personally I can't say this makes things clearer. -- With Best Regards, Andy Shevchenko