Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbdGOUc5 (ORCPT ); Sat, 15 Jul 2017 16:32:57 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:65408 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbdGOUcv (ORCPT ); Sat, 15 Jul 2017 16:32:51 -0400 X-IronPort-AV: E=Sophos;i="5.40,365,1496095200"; d="scan'208";a="231634444" From: Julia Lawall To: Lee Jones Cc: keescook@chromium.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] mfd: max8925-i2c: Drop unnecessary static Date: Sat, 15 Jul 2017 22:07:46 +0200 Message-Id: <1500149266-32357-12-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1500149266-32357-1-git-send-email-Julia.Lawall@lip6.fr> References: <1500149266-32357-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 49 Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; // Signed-off-by: Julia Lawall --- These patches are all independent of each other. drivers/mfd/max8925-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c --- a/drivers/mfd/max8925-i2c.c +++ b/drivers/mfd/max8925-i2c.c @@ -151,7 +151,7 @@ static int max8925_probe(struct i2c_clie const struct i2c_device_id *id) { struct max8925_platform_data *pdata = dev_get_platdata(&client->dev); - static struct max8925_chip *chip; + struct max8925_chip *chip; struct device_node *node = client->dev.of_node; if (node && !pdata) {