Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751253AbdGPHQA convert rfc822-to-8bit (ORCPT ); Sun, 16 Jul 2017 03:16:00 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:55736 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbdGPHP6 (ORCPT ); Sun, 16 Jul 2017 03:15:58 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices From: Marcel Holtmann In-Reply-To: <1499340593-12739-1-git-send-email-hanipouspilot@gmail.com> Date: Sun, 16 Jul 2017 09:15:56 +0200 Cc: "Gustavo F. Padovan" , Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <27C5C78B-0335-4E25-82CF-D01233D76A85@holtmann.org> References: <1499340593-12739-1-git-send-email-hanipouspilot@gmail.com> To: Dmitry Tunin X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1570 Lines: 43 Hi Dmitry, > There is another device > > T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=105b ProdID=e066 Rev=01.12 > S: Manufacturer=Broadcom Corp > S: Product=BCM20702A0 > S: SerialNumber=342387DAE35E > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) > > Since we have Cls=ff, we can add all of them. > > Signed-off-by: Dmitry Tunin > Cc: stable@vger.kernel.org > --- > drivers/bluetooth/btusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index fa24d69..bf95c13 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = { > { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM }, > > /* Broadcom BCM43142A0 (Foxconn/Lenovo) */ > - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM }, > + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01), > > /* Broadcom BCM920703 (HTC Vive) */ > { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01), this patch is garbled up. And please include full /sys/kernel/debug/usb/devices for these ones. Regards Marcel