Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751262AbdGPH5B (ORCPT ); Sun, 16 Jul 2017 03:57:01 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:36208 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbdGPH47 (ORCPT ); Sun, 16 Jul 2017 03:56:59 -0400 MIME-Version: 1.0 In-Reply-To: <27C5C78B-0335-4E25-82CF-D01233D76A85@holtmann.org> References: <1499340593-12739-1-git-send-email-hanipouspilot@gmail.com> <27C5C78B-0335-4E25-82CF-D01233D76A85@holtmann.org> From: Dmitry Tunin Date: Sun, 16 Jul 2017 10:56:58 +0300 Message-ID: Subject: Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices To: Marcel Holtmann Cc: "Gustavo F. Padovan" , Johan Hedberg , linux-bluetooth , linux-kernel , "stable@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1946 Lines: 50 The one that is in your tree is correct. I see the problem. I added the Cc: stable... to the first one and it got through there. My apologies, I received the patch by mail and forwarded it. In a second I found out the crap and fixed it. 2017-07-16 10:15 GMT+03:00 Marcel Holtmann : > Hi Dmitry, > >> There is another device >> >> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 >> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 >> P: Vendor=105b ProdID=e066 Rev=01.12 >> S: Manufacturer=Broadcom Corp >> S: Product=BCM20702A0 >> S: SerialNumber=342387DAE35E >> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA >> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) >> >> Since we have Cls=ff, we can add all of them. >> >> Signed-off-by: Dmitry Tunin >> Cc: stable@vger.kernel.org >> --- >> drivers/bluetooth/btusb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c >> index fa24d69..bf95c13 100644 >> --- a/drivers/bluetooth/btusb.c >> +++ b/drivers/bluetooth/btusb.c >> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = { >> { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM }, >> >> /* Broadcom BCM43142A0 (Foxconn/Lenovo) */ >> - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM }, >> + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01), >> >> /* Broadcom BCM920703 (HTC Vive) */ >> { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01), > > this patch is garbled up. And please include full /sys/kernel/debug/usb/devices for these ones. > > Regards > > Marcel >