Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751286AbdGPLYr (ORCPT ); Sun, 16 Jul 2017 07:24:47 -0400 Received: from mga04.intel.com ([192.55.52.120]:10718 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbdGPLYq (ORCPT ); Sun, 16 Jul 2017 07:24:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,368,1496127600"; d="scan'208";a="287474147" Message-ID: <1500204280.8397.4.camel@linux.intel.com> Subject: Re: [PATCH] tpm: tpm_crb: constify acpi_device_id. From: Jarkko Sakkinen To: Arvind Yadav , peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Date: Sun, 16 Jul 2017 14:24:40 +0300 In-Reply-To: <8a670ac215126b76d72861319a0d45e17759ad66.1499363107.git.arvind.yadav.cs@gmail.com> References: <8a670ac215126b76d72861319a0d45e17759ad66.1499363107.git.arvind.yadav.cs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.3-0ubuntu4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 35 On Thu, 2017-07-06 at 23:18 +0530, Arvind Yadav wrote: > acpi_device_id are not supposed to change at runtime. All functions > working with acpi_device_id provided by work with > const acpi_device_id. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 4198 608 0 4806 12c6 drivers/char/tpm/tpm_crb.o > > File size After adding 'const': > text data bss dec hex filename > 4262 520 0 4782 12ae drivers/char/tpm/tpm_crb.o > > Signed-off-by: Arvind Yadav > --- > drivers/char/tpm/tpm_crb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c > index b917b9d..bf7189e 100644 > --- a/drivers/char/tpm/tpm_crb.c > +++ b/drivers/char/tpm/tpm_crb.c > @@ -665,7 +665,7 @@ static const struct dev_pm_ops crb_pm = { > SET_RUNTIME_PM_OPS(crb_pm_runtime_suspend, crb_pm_runtime_resume, NULL) > }; > > -static struct acpi_device_id crb_device_ids[] = { > +static const struct acpi_device_id crb_device_ids[] = { > {"MSFT0101", 0}, > {"", 0}, > }; Applied. /Jarkko