Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751312AbdGPMTc (ORCPT ); Sun, 16 Jul 2017 08:19:32 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751087AbdGPMTb (ORCPT ); Sun, 16 Jul 2017 08:19:31 -0400 Subject: Re: [PATCH 2/4] ubifs: Fix unlink code wrt. double hash lookups From: Richard Weinberger To: Geert Uytterhoeven Cc: Hyunchul Lee , kernel-team@lge.com, Artem Bityutskiy , MTD Maling List , david.oberhollenzer@sigma-star.at, "linux-kernel@vger.kernel.org" References: <20170209212837.14197-1-richard@nod.at> <20170209212837.14197-2-richard@nod.at> <20170309070439.GA31469@sebu> Message-ID: Date: Sun, 16 Jul 2017 14:19:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 706 Lines: 23 Am 16.07.2017 um 14:17 schrieb Richard Weinberger: > Geert, > > Am 16.07.2017 um 14:12 schrieb Geert Uytterhoeven: >> Hi Richard, >> >> On Sun, Mar 19, 2017 at 9:46 PM, Richard Weinberger wrote: >>> Am 09.03.2017 um 08:04 schrieb Hyunchul Lee: >>>>> - int n, err, type = key_type(c, key); >>>>> - struct ubifs_znode *znode; >>>>> + int err; >> >> fs/ubifs/tnc.c: In function ‘search_dh_cookie’: >> fs/ubifs/tnc.c:1893: warning: ‘err’ is used uninitialized in this function >> >> None of Hyunchul's review comments below ended up in commit 781f675e2d7ec120 >> ("ubifs: Fix unlink code wrt. double hash lookups")? > > Oh, that was not indented. *intentional ;)