Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751265AbdGPP7e (ORCPT ); Sun, 16 Jul 2017 11:59:34 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:35205 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbdGPP7d (ORCPT ); Sun, 16 Jul 2017 11:59:33 -0400 MIME-Version: 1.0 In-Reply-To: <1500180236.5334.7.camel@gmx.de> References: <1500097200.6712.17.camel@gmx.de> <1500180236.5334.7.camel@gmx.de> From: Ilia Mirkin Date: Sun, 16 Jul 2017 11:59:32 -0400 X-Google-Sender-Auth: LCknx2oOQPMc6y479Rr8TnWkKok Message-ID: Subject: Re: [drm/nouveau] GeForce 8600 GT boot/suspend grumbling To: Mike Galbraith Cc: "dri-devel@lists.freedesktop.org" , "nouveau@lists.freedesktop.org" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 868 Lines: 17 On Sun, Jul 16, 2017 at 12:43 AM, Mike Galbraith wrote: > On Sat, 2017-07-15 at 14:52 -0400, Ilia Mirkin wrote: >> >> OK, so this issue appears to be that we're calling >> drm_crtc_vblank_off() on a crtc for which vblank is already disabled. >> My guess is that this happens because the crtc is disabled. >> >> Not sure what the proper check is to see if vblanks are already disabled... > > Seems so, the below shut up suspend for both 8600 GT and GTX 980. The modeset done by drm_atomic_helper_suspend (called previously to that *_fini) should already take care of disabling vblanks, I think. So the vblank_off calls can just be done when we're not doing an atomic modeset [drm_drv_uses_atomic_modeset(dev)] -- this is all very confusing since pre-nv50 uses legacy modesets, while nv50+ has been moved to atomic, but they share a bunch of helpers =/