Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751285AbdGQC2P (ORCPT ); Sun, 16 Jul 2017 22:28:15 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:52811 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbdGQC2O (ORCPT ); Sun, 16 Jul 2017 22:28:14 -0400 From: Laurent Pinchart To: Jacob Chen Cc: "open list:ARM/Rockchip SoC..." , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Heiko Stuebner , robh+dt@kernel.org, Mauro Carvalho Chehab , Linux Media Mailing List , laurent.pinchart+renesas@ideasonboard.com, Hans Verkuil , s.nawrocki@samsung.com, Tomasz Figa , Nicolas Dufresne Subject: Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Date: Mon, 17 Jul 2017 05:28:20 +0300 Message-ID: <3257165.sao50mFgxX@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: References: <1500101920-24039-1-git-send-email-jacob-chen@iotwrt.com> <2238838.k7NpPUxaC0@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 34 Hi Jacob, On Sunday 16 Jul 2017 12:23:02 Jacob Chen wrote: > 2017-07-15 17:16 GMT+08:00 Laurent Pinchart: > > On Saturday 15 Jul 2017 14:58:39 Jacob Chen wrote: > >> Signed-off-by: Jacob Chen > >> --- > >> > >> arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++ > >> arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 4 ++++ > >> arch/arm/boot/dts/rk3288-firefly.dtsi | 4 ++++ > >> arch/arm/boot/dts/rk3288-miqi.dts | 4 ++++ > >> arch/arm/boot/dts/rk3288-popmetal.dts | 4 ++++ > >> arch/arm/boot/dts/rk3288-tinker.dts | 4 ++++ > > > > Some boards are missing from this list (Fennec, Phycore, ...) What > > criteria have you used to decide on which ones to enable the RGA ? That > > should be explained in the commit message. > > Ok. > > I just enable the boards i have tested, because i can't make sure it > won't break the other board because of clocks or power-domains. Given the clocks and power domains shouldn't be board-specific, would it make sense to try and get the change tested on the remaining boards ? You could then enable the device in the SoC .dtsi file, which would be much simpler. > >> 6 files changed, 24 insertions(+) -- Regards, Laurent Pinchart