Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbdGQD6l (ORCPT ); Sun, 16 Jul 2017 23:58:41 -0400 Received: from gateway32.websitewelcome.com ([192.185.145.102]:18018 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbdGQD6j (ORCPT ); Sun, 16 Jul 2017 23:58:39 -0400 Subject: Re: [PATCH] st-delta: constify vb2_ops structures To: Hugues FRUCHET , Mauro Carvalho Chehab References: <20170706201423.GA7477@embeddedgus> Cc: "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: "Gustavo A. R. Silva" Message-ID: Date: Sun, 16 Jul 2017 22:58:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWxB8-002gmX-RE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:38666 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2111 Lines: 70 Thank you, Hugues. On 07/07/2017 09:33 AM, Hugues FRUCHET wrote: > Acked-by: Hugues Fruchet > > On 07/06/2017 10:14 PM, Gustavo A. R. Silva wrote: >> Check for vb2_ops structures that are only stored in the ops field of a >> vb2_queue structure. That field is declared const, so vb2_ops structures >> that have this property can be declared as const also. >> >> This issue was detected using Coccinelle and the following semantic patch: >> >> @r disable optional_qualifier@ >> identifier i; >> position p; >> @@ >> static struct vb2_ops i@p = { ... }; >> >> @ok@ >> identifier r.i; >> struct vb2_queue e; >> position p; >> @@ >> e.ops = &i@p; >> >> @bad@ >> position p != {r.p,ok.p}; >> identifier r.i; >> struct vb2_ops e; >> @@ >> e@i@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r.i; >> @@ >> static >> +const >> struct vb2_ops i = { ... }; >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/media/platform/sti/delta/delta-v4l2.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/media/platform/sti/delta/delta-v4l2.c b/drivers/media/platform/sti/delta/delta-v4l2.c >> index c6f2e24..ff9850e 100644 >> --- a/drivers/media/platform/sti/delta/delta-v4l2.c >> +++ b/drivers/media/platform/sti/delta/delta-v4l2.c >> @@ -1574,7 +1574,7 @@ static void delta_vb2_frame_stop_streaming(struct vb2_queue *q) >> } >> >> /* VB2 queue ops */ >> -static struct vb2_ops delta_vb2_au_ops = { >> +static const struct vb2_ops delta_vb2_au_ops = { >> .queue_setup = delta_vb2_au_queue_setup, >> .buf_prepare = delta_vb2_au_prepare, >> .buf_queue = delta_vb2_au_queue, >> @@ -1584,7 +1584,7 @@ static struct vb2_ops delta_vb2_au_ops = { >> .stop_streaming = delta_vb2_au_stop_streaming, >> }; >> >> -static struct vb2_ops delta_vb2_frame_ops = { >> +static const struct vb2_ops delta_vb2_frame_ops = { >> .queue_setup = delta_vb2_frame_queue_setup, >> .buf_prepare = delta_vb2_frame_prepare, >> .buf_finish = delta_vb2_frame_finish, -- Gustavo A. R. Silva