Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbdGQEBT (ORCPT ); Mon, 17 Jul 2017 00:01:19 -0400 Received: from gateway31.websitewelcome.com ([192.185.143.52]:23266 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbdGQEBS (ORCPT ); Mon, 17 Jul 2017 00:01:18 -0400 Subject: Re: [PATCH] stm32-dcmi: constify vb2_ops structure To: Hugues FRUCHET , Mauro Carvalho Chehab , Maxime Coquelin , Alexandre TORGUE References: <20170706200517.GA5886@embeddedgus> Cc: "linux-media@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" From: "Gustavo A. R. Silva" Message-ID: <52e9bcd7-6a85-4200-4418-83e3de547643@embeddedor.com> Date: Sun, 16 Jul 2017 23:01:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWxDh-002ij8-6P X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:38790 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 7 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1694 Lines: 61 On 07/07/2017 09:33 AM, Hugues FRUCHET wrote: > Acked-by: Hugues Fruchet Thank you, Hugues. > On 07/06/2017 10:05 PM, Gustavo A. R. Silva wrote: >> Check for vb2_ops structures that are only stored in the ops field of a >> vb2_queue structure. That field is declared const, so vb2_ops structures >> that have this property can be declared as const also. >> >> This issue was detected using Coccinelle and the following semantic patch: >> >> @r disable optional_qualifier@ >> identifier i; >> position p; >> @@ >> static struct vb2_ops i@p = { ... }; >> >> @ok@ >> identifier r.i; >> struct vb2_queue e; >> position p; >> @@ >> e.ops = &i@p; >> >> @bad@ >> position p != {r.p,ok.p}; >> identifier r.i; >> struct vb2_ops e; >> @@ >> e@i@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r.i; >> @@ >> static >> +const >> struct vb2_ops i = { ... }; >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/media/platform/stm32/stm32-dcmi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c >> index 83d32a5..24ef888 100644 >> --- a/drivers/media/platform/stm32/stm32-dcmi.c >> +++ b/drivers/media/platform/stm32/stm32-dcmi.c >> @@ -662,7 +662,7 @@ static void dcmi_stop_streaming(struct vb2_queue *vq) >> dcmi->errors_count, dcmi->buffers_count); >> } >> >> -static struct vb2_ops dcmi_video_qops = { >> +static const struct vb2_ops dcmi_video_qops = { >> .queue_setup = dcmi_queue_setup, >> .buf_init = dcmi_buf_init, >> .buf_prepare = dcmi_buf_prepare, -- Gustavo A. R. Silva