Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751315AbdGQEDx (ORCPT ); Mon, 17 Jul 2017 00:03:53 -0400 Received: from gateway31.websitewelcome.com ([192.185.143.52]:33159 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbdGQEDw (ORCPT ); Mon, 17 Jul 2017 00:03:52 -0400 Subject: Re: [PATCH] watchdog: coh901327_wdt: constify watchdog_ops structure To: Guenter Roeck , Linus Walleij , Wim Van Sebroeck References: <20170708003330.GA15374@embeddedgus> <031cf1ab-7f1b-4e4d-adaf-efa6c3af8040@roeck-us.net> Cc: linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Message-ID: <72fb7a2e-f075-57b0-72e2-6c16205eaf4e@embeddedor.com> Date: Sun, 16 Jul 2017 23:03:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <031cf1ab-7f1b-4e4d-adaf-efa6c3af8040@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWxGB-002kPo-N8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:38804 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 17 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 71 On 07/07/2017 08:45 PM, Guenter Roeck wrote: > On 07/07/2017 05:33 PM, Gustavo A. R. Silva wrote: >> Check for watchdog_ops structures that are only stored in the ops >> field of >> a watchdog_device structure. This field is declared const, so >> watchdog_ops >> structures that have this property can be declared as const also. >> >> This issue was detected using Coccinelle and the following semantic >> patch: >> >> @r >> disable optional_qualifier@ >> identifier i; >> position p; >> @@ >> static struct watchdog_ops i@p = { ... }; >> >> @ok@ >> identifier r.i; >> struct watchdog_device e; >> position p; >> @@ >> e.ops = &i@p; >> >> @bad@ >> position p != {r.p,ok.p}; >> identifier r.i; >> struct watchdog_ops e; >> @@ >> e@i@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r.i; >> @@ >> static >> +const >> struct watchdog_ops i = { ... }; >> >> Signed-off-by: Gustavo A. R. Silva > > Reviewed-by: Guenter Roeck > Thank you, Guenter. >> --- >> drivers/watchdog/coh901327_wdt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/watchdog/coh901327_wdt.c >> b/drivers/watchdog/coh901327_wdt.c >> index 38dd60f0..4410337 100644 >> --- a/drivers/watchdog/coh901327_wdt.c >> +++ b/drivers/watchdog/coh901327_wdt.c >> @@ -218,7 +218,7 @@ static const struct watchdog_info coh901327_ident >> = { >> .identity = DRV_NAME, >> }; >> -static struct watchdog_ops coh901327_ops = { >> +static const struct watchdog_ops coh901327_ops = { >> .owner = THIS_MODULE, >> .start = coh901327_start, >> .stop = coh901327_stop, >> > -- Gustavo A. R. Silva