Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751315AbdGQEMT (ORCPT ); Mon, 17 Jul 2017 00:12:19 -0400 Received: from gateway36.websitewelcome.com ([192.185.192.36]:25544 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbdGQEMS (ORCPT ); Mon, 17 Jul 2017 00:12:18 -0400 Subject: Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure To: Eric Anholt , Linus Walleij , Florian Fainelli , Ray Jui , Scott Branden , Stefan Wahren References: <20170711180339.GA17806@embeddedgus> <877ezdh3jn.fsf@eliezer.anholt.net> Cc: bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Message-ID: Date: Sun, 16 Jul 2017 23:12:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <877ezdh3jn.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWxOL-002pSz-Nx X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:38866 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 44 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 35 On 07/12/2017 02:13 PM, Eric Anholt wrote: > "Gustavo A. R. Silva" writes: > >> This structure is only used to copy into other structure, so declare >> it as const. >> >> This issue was detected using Coccinelle and the following semantic patch: > Acked-by: Eric Anholt Thank you, Eric >> --- >> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c >> index 2308831..7203f35 100644 >> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c >> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c >> @@ -353,7 +353,7 @@ static int bcm2835_gpio_direction_output(struct gpio_chip *chip, >> return pinctrl_gpio_direction_output(chip->base + offset); >> } >> >> -static struct gpio_chip bcm2835_gpio_chip = { >> +static const struct gpio_chip bcm2835_gpio_chip = { >> .label = MODULE_NAME, >> .owner = THIS_MODULE, >> .request = gpiochip_generic_request, >> -- >> 2.5.0 -- Gustavo A. R. Silva