Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751292AbdGQEwG (ORCPT ); Mon, 17 Jul 2017 00:52:06 -0400 Received: from gateway20.websitewelcome.com ([192.185.64.36]:33495 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbdGQEwF (ORCPT ); Mon, 17 Jul 2017 00:52:05 -0400 Subject: Re: [PATCH v2] devfreq: tegra: fix error return code in tegra_devfreq_probe() To: Jon Hunter , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding References: <20170703124738.GA3947@embeddedgus> <5206e248-a3a7-8cb5-5d8f-a0c84bcb9e40@nvidia.com> Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Message-ID: <38a5cf39-26a4-8498-add8-423dc39e3219@embeddedor.com> Date: Sun, 16 Jul 2017 23:52:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <5206e248-a3a7-8cb5-5d8f-a0c84bcb9e40@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWy0q-003DqJ-1m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:39772 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 81 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1561 Lines: 51 On 07/04/2017 03:35 AM, Jon Hunter wrote: > > On 03/07/17 13:47, Gustavo A. R. Silva wrote: >> platform_get_irq() returns an error code, but the tegra-devfreq >> driver ignores it and always returns -ENODEV. This is not correct, >> and prevents -EPROBE_DEFER from being propagated properly. >> >> Notice that platform_get_irq() no longer returns 0 on error: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af >> >> Print and propagate the return value of platform_get_irq on failure. >> >> Reviewed-by: Chanwoo Choi >> Acked-by: MyungJoo Ham >> Signed-off-by: Gustavo A. R. Silva >> --- >> Changes in v2: >> Rewrite commit message. >> >> drivers/devfreq/tegra-devfreq.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >> index 214fff9..ae71215 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) >> } >> >> irq = platform_get_irq(pdev, 0); >> - if (irq <= 0) { >> - dev_err(&pdev->dev, "Failed to get IRQ\n"); >> - return -ENODEV; >> + if (irq < 0) { >> + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); >> + return irq; >> } >> >> platform_set_drvdata(pdev, tegra); > > Thanks. > > Acked-by: Jon Hunter > Thank you, Jon. -- Gustavo A. R. Silva