Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751304AbdGQEx0 (ORCPT ); Mon, 17 Jul 2017 00:53:26 -0400 Received: from gateway33.websitewelcome.com ([192.185.146.195]:34207 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbdGQExZ (ORCPT ); Mon, 17 Jul 2017 00:53:25 -0400 Subject: Re: [PATCH] mmc: mxcmmc: fix error return code in mxcmci_probe() To: Ulf Hansson References: <20170707055928.GA11041@embeddedgus> Cc: "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: "Gustavo A. R. Silva" Message-ID: <58cd3a01-d2a4-936f-d19e-120f4824e798@embeddedor.com> Date: Sun, 16 Jul 2017 23:53:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWy29-003EdF-1D X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:39798 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 84 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1348 Lines: 48 Hi Ulf, On 07/11/2017 09:43 AM, Ulf Hansson wrote: > On 7 July 2017 at 07:59, Gustavo A. R. Silva wrote: >> platform_get_irq() returns an error code, but the mxcmmc driver >> ignores it and always returns -EINVAL. This is not correct, >> and prevents -EPROBE_DEFER from being propagated properly. >> >> Print error message and propagate the return value of >> platform_get_irq on failure. >> >> Signed-off-by: Gustavo A. R. Silva > > Thanks, applied for next! > Thank you! > Kind regards > Uffe > >> --- >> drivers/mmc/host/mxcmmc.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c >> index fb3ca82..f3c2832 100644 >> --- a/drivers/mmc/host/mxcmmc.c >> +++ b/drivers/mmc/host/mxcmmc.c >> @@ -1014,8 +1014,10 @@ static int mxcmci_probe(struct platform_device *pdev) >> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> irq = platform_get_irq(pdev, 0); >> - if (irq < 0) >> - return -EINVAL; >> + if (irq < 0) { >> + dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq); >> + return irq; >> + } >> >> mmc = mmc_alloc_host(sizeof(*host), &pdev->dev); >> if (!mmc) >> -- >> 2.5.0 >> -- Gustavo A. R. Silva