Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751289AbdGQE4U (ORCPT ); Mon, 17 Jul 2017 00:56:20 -0400 Received: from gateway34.websitewelcome.com ([192.185.149.62]:46986 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbdGQE4S (ORCPT ); Mon, 17 Jul 2017 00:56:18 -0400 Subject: Re: [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value To: Jonathan Cameron , Martin Blumenstingl References: <20170707064630.GA21945@embeddedgus> <20170709190843.0bfa292f@kernel.org> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Carlo Caione , Kevin Hilman , linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: "Gustavo A. R. Silva" Message-ID: <96a56ec0-898e-5339-a0aa-81c6f8e96d88@embeddedor.com> Date: Sun, 16 Jul 2017 23:55:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170709190843.0bfa292f@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWy4w-003GIM-7h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:39830 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 94 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1967 Lines: 63 On 07/09/2017 01:08 PM, Jonathan Cameron wrote: > On Sat, 8 Jul 2017 15:42:46 +0200 > Martin Blumenstingl wrote: > >> On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva >> wrote: >>> Check return value from call to of_match_device() >>> in order to prevent a NULL pointer dereference. >>> >>> In case of NULL print error message and return -ENODEV >>> >>> Signed-off-by: Gustavo A. R. Silva >> thanks for finding this. a crash here is a rather theoretical problem >> (since all compatible strings have their corresponding match data) - >> but it doesn't hurt either, so: >> >> Acked-by: Martin Blumenstingl > Applied. > Thank you, Jonathan. > Jonathan >> >> >>> --- >>> drivers/iio/adc/meson_saradc.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c >>> index 83da50e..07dbcc3 100644 >>> --- a/drivers/iio/adc/meson_saradc.c >>> +++ b/drivers/iio/adc/meson_saradc.c >>> @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev) >>> init_completion(&priv->done); >>> >>> match = of_match_device(meson_sar_adc_of_match, &pdev->dev); >>> + if (!match) { >>> + dev_err(&pdev->dev, "failed to match device\n"); >>> + return -ENODEV; >>> + } >>> + >>> priv->data = match->data; >>> >>> indio_dev->name = priv->data->name; >>> -- >>> 2.5.0 >>> >>> >>> _______________________________________________ >>> linux-amlogic mailing list >>> linux-amlogic@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-amlogic >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Gustavo A. R. Silva