Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbdGQE5x (ORCPT ); Mon, 17 Jul 2017 00:57:53 -0400 Received: from gateway31.websitewelcome.com ([192.185.144.80]:14324 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbdGQE5v (ORCPT ); Mon, 17 Jul 2017 00:57:51 -0400 Subject: Re: [PATCH] iio: adc: rockchip_saradc: add NULL check on of_match_device() return value To: Jonathan Cameron References: <20170707065131.GA23382@embeddedgus> <20170709191007.5d79c950@kernel.org> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Heiko Stuebner , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Message-ID: Date: Sun, 16 Jul 2017 23:57:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170709191007.5d79c950@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWy6R-003HHs-B4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:39846 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 104 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 437 Lines: 19 On 07/09/2017 01:10 PM, Jonathan Cameron wrote: > On Fri, 7 Jul 2017 01:51:31 -0500 > "Gustavo A. R. Silva" wrote: > >> Check return value from call to of_match_device() >> in order to prevent a NULL pointer dereference. >> >> In case of NULL print error message and return -ENODEV >> >> Signed-off-by: Gustavo A. R. Silva > Applied. > Thank you, Jonathan. -- Gustavo A. R. Silva