Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751314AbdGQE6z (ORCPT ); Mon, 17 Jul 2017 00:58:55 -0400 Received: from gateway20.websitewelcome.com ([192.185.64.36]:28751 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbdGQE6y (ORCPT ); Mon, 17 Jul 2017 00:58:54 -0400 Subject: Re: [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value To: Moritz Fischer References: <20170707062214.GA16142@embeddedgus> Cc: Alan Tull , linux-fpga@vger.kernel.org, Linux Kernel Mailing List From: "Gustavo A. R. Silva" Message-ID: Date: Sun, 16 Jul 2017 23:58:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWy7R-003HtZ-7P X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:39858 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 108 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 41 On 07/10/2017 11:25 AM, Moritz Fischer wrote: > On Thu, Jul 6, 2017 at 11:22 PM, Gustavo A. R. Silva > wrote: >> Check return value from call to of_match_device() >> in order to prevent a NULL pointer dereference. >> >> In case of NULL print error message and return -ENODEV >> >> Signed-off-by: Gustavo A. R. Silva > Reviewed-by: Moritz Fischer Thank you, Moritz. >> --- >> drivers/fpga/altera-hps2fpga.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c >> index 3066b80..ca8212c 100644 >> --- a/drivers/fpga/altera-hps2fpga.c >> +++ b/drivers/fpga/altera-hps2fpga.c >> @@ -143,6 +143,11 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev) >> int ret; >> >> of_id = of_match_device(altera_fpga_of_match, dev); >> + if (!of_id) { >> + dev_err(dev, "failed to match device\n"); >> + return -ENODEV; >> + } >> + >> priv = (struct altera_hps2fpga_data *)of_id->data; >> >> priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0); >> -- >> 2.5.0 >> -- Gustavo A. R. Silva