Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751280AbdGQFA4 (ORCPT ); Mon, 17 Jul 2017 01:00:56 -0400 Received: from gateway31.websitewelcome.com ([192.185.144.80]:42053 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbdGQFAz (ORCPT ); Mon, 17 Jul 2017 01:00:55 -0400 Subject: Re: [PATCH] HID: hid-logitech-hidpp: add NULL check on devm_kmemdup() return value To: Benjamin Tissoires References: <20170707051213.GA6074@embeddedgus> <20170712074035.GF22282@mail.corp.redhat.com> Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Message-ID: <6913c916-93f7-4b25-8183-676a7cd009b0@embeddedor.com> Date: Mon, 17 Jul 2017 00:00:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170712074035.GF22282@mail.corp.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dWy9O-003JCX-02 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.152.152.176]:39912 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 38 On 07/12/2017 02:40 AM, Benjamin Tissoires wrote: > On Jul 07 2017 or thereabouts, Gustavo A. R. Silva wrote: >> Check return value from call to devm_kmemdup() >> in order to prevent a NULL pointer dereference. >> >> Signed-off-by: Gustavo A. R. Silva >> --- > > Reviewed-by: Benjamin Tissoires > Thank you, Benjamin. >> drivers/hid/hid-logitech-hidpp.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c >> index 41b3946..501e16a 100644 >> --- a/drivers/hid/hid-logitech-hidpp.c >> +++ b/drivers/hid/hid-logitech-hidpp.c >> @@ -2732,6 +2732,9 @@ static int hidpp_initialize_battery(struct hidpp_device *hidpp) >> hidpp_battery_props, >> sizeof(hidpp_battery_props), >> GFP_KERNEL); >> + if (!battery_props) >> + return -ENOMEM; >> + >> num_battery_props = ARRAY_SIZE(hidpp_battery_props) - 2; >> >> if (hidpp->capabilities & HIDPP_CAPABILITY_BATTERY_MILEAGE) >> -- >> 2.5.0 >> -- Gustavo A. R. Silva