Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751329AbdGQGid (ORCPT ); Mon, 17 Jul 2017 02:38:33 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52870 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbdGQGib (ORCPT ); Mon, 17 Jul 2017 02:38:31 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 17 Jul 2017 12:08:30 +0530 From: Abhishek Sahu To: Boris Brezillon Cc: Marek Vasut , dwmw2@infradead.org, computersforpeace@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, architt@codeaurora.org, sricharan@codeaurora.org Subject: Re: [PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH In-Reply-To: <20170703214735.2acb70cc@bbrezillon> References: <1498720566-20782-1-git-send-email-absahu@codeaurora.org> <1498720566-20782-4-git-send-email-absahu@codeaurora.org> <20170703214735.2acb70cc@bbrezillon> Message-ID: <8726fbe7c72f1b25154c9d0a30e20a49@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 43 On 2017-07-04 01:17, Boris Brezillon wrote: > On Thu, 29 Jun 2017 11:49:07 +0200 > Marek Vasut wrote: > >> On 06/29/2017 09:15 AM, Abhishek Sahu wrote: >> > The configuration for BCH is not correct in the current >> > driver so this patch fixed the same. >> >> Fix the commit message, I have no idea what this patch does or fixes. > > And please add a Fixes tag and Cc stable. > Sure. I will amend the commit message to make it more clear and will include these tags. >> >> > Signed-off-by: Abhishek Sahu >> > --- >> > drivers/mtd/nand/qcom_nandc.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/mtd/nand/qcom_nandc.c > b/drivers/mtd/nand/qcom_nandc.c >> > index 520add9..410ee53 100644 >> > --- a/drivers/mtd/nand/qcom_nandc.c >> > +++ b/drivers/mtd/nand/qcom_nandc.c >> > @@ -1919,7 +1919,7 @@ static int qcom_nand_host_setup(struct > qcom_nand_host *host) >> > | wide_bus << WIDE_FLASH >> > | 1 << DEV0_CFG1_ECC_DISABLE; >> > >> > - host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE >> > + host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE >> > | 0 << ECC_SW_RESET >> > | host->cw_data << ECC_NUM_DATA_BYTES >> > | 1 << ECC_FORCE_CLK_OPEN >> > >> >> -- Abhishek Sahu