Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751309AbdGQHbA convert rfc822-to-8bit (ORCPT ); Mon, 17 Jul 2017 03:31:00 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:49229 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbdGQHa6 (ORCPT ); Mon, 17 Jul 2017 03:30:58 -0400 From: Gabriel FERNANDEZ To: Michael Turquette , Stephen Boyd CC: Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre TORGUE , Nicolas Pitre , Arnd Bergmann , "daniel.thompson@linaro.org" , "andrea.merello@gmail.com" , "radoslaw.pietrzyk@gmail.com" , Lee Jones , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , Ludovic BARRE , "Olivier BIDEAU" , Amelie DELAUNAY , "gabriel.fernandez.st@gmail.com" Subject: Re: [PATCH v5 1/2] clk: gate: expose clk_gate_ops::is_enabled Thread-Topic: [PATCH v5 1/2] clk: gate: expose clk_gate_ops::is_enabled Thread-Index: AQHS++CuTSP6AmBLdUKtVvh0LvBiZqJTi2cAgAP4WAA= Date: Mon, 17 Jul 2017 07:30:08 +0000 Message-ID: References: <201707150222.ogIMUhKu%fengguang.wu@intel.com> In-Reply-To: <201707150222.ogIMUhKu%fengguang.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="Windows-1252" Content-ID: <330E8A5A02C3C34898FA214134A60526@st.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-17_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3005 Lines: 65 Hi Stephen, On 07/14/2017 08:52 PM, kbuild test robot wrote: > Hi Gabriel, > > [auto build test ERROR on clk/clk-next] > [also build test ERROR on v4.12 next-20170714] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/gabriel-fernandez-st-com/clk-stm32h7-Add-stm32h743-clock-driver/20170714-170518 > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next > config: arm-lpc32xx_defconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > >>> drivers/clk/nxp/clk-lpc32xx.c:906:12: error: static declaration of 'clk_gate_is_enabled' follows non-static declaration > static int clk_gate_is_enabled(struct clk_hw *hw) > ^~~~~~~~~~~~~~~~~~~ > In file included from drivers/clk/nxp/clk-lpc32xx.c:13:0: > include/linux/clk-provider.h:346:5: note: previous declaration of 'clk_gate_is_enabled' was here > int clk_gate_is_enabled(struct clk_hw *hw); > ^~~~~~~~~~~~~~~~~~~ > > vim +/clk_gate_is_enabled +906 drivers/clk/nxp/clk-lpc32xx.c > > f7c82a60 Vladimir Zapolskiy 2015-12-06 905 > f7c82a60 Vladimir Zapolskiy 2015-12-06 @906 static int clk_gate_is_enabled(struct clk_hw *hw) > f7c82a60 Vladimir Zapolskiy 2015-12-06 907 { > f7c82a60 Vladimir Zapolskiy 2015-12-06 908 struct lpc32xx_clk_gate *clk = to_lpc32xx_gate(hw); > f7c82a60 Vladimir Zapolskiy 2015-12-06 909 u32 val; > f7c82a60 Vladimir Zapolskiy 2015-12-06 910 bool is_set; > f7c82a60 Vladimir Zapolskiy 2015-12-06 911 > f7c82a60 Vladimir Zapolskiy 2015-12-06 912 regmap_read(clk_regmap, clk->reg, &val); > f7c82a60 Vladimir Zapolskiy 2015-12-06 913 is_set = val & BIT(clk->bit_idx); > f7c82a60 Vladimir Zapolskiy 2015-12-06 914 > f7c82a60 Vladimir Zapolskiy 2015-12-06 915 return (clk->flags & CLK_GATE_SET_TO_DISABLE ? !is_set : is_set); > f7c82a60 Vladimir Zapolskiy 2015-12-06 916 } > f7c82a60 Vladimir Zapolskiy 2015-12-06 917 EXPORT_SYMBOL_GPL(__clk_gate_is_enabled); > > > :::::: The code at line 906 was first introduced by commit > :::::: f7c82a60ba26c2f003662bcb2cff131021c1e828 clk: lpc32xx: add common clock framework driver > > :::::: TO: Vladimir Zapolskiy > :::::: CC: Michael Turquette > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation Rename 'clk_gate_is_enabled' into'__clk_gate_is_enabled' from clk-gate.c file, is it a good solution for you ? i could add also EXPORT_SYMBOL_GPL(__clk_gate_is_enabled) if you are ok. Best Regards Gabriel