Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751315AbdGQHlh (ORCPT ); Mon, 17 Jul 2017 03:41:37 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33781 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbdGQHlg (ORCPT ); Mon, 17 Jul 2017 03:41:36 -0400 Subject: Re: [PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures. To: oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1500270540-5928-1-git-send-email-arvind.yadav.cs@gmail.com> <1500270540-5928-5-git-send-email-arvind.yadav.cs@gmail.com> Cc: john.hammond@intel.com, dmitry.eremin@intel.com, fan.yong@intel.com From: Arvind Yadav Message-ID: <84171e90-fd40-43f8-46b4-8645a60aab6e@gmail.com> Date: Mon, 17 Jul 2017 13:11:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1500270540-5928-5-git-send-email-arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 27 Sorry for noise. Please ignore this. This change should not be separate. ~arvind On Monday 17 July 2017 11:19 AM, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work > with const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > index bc19f19..ba41983 100644 > --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > @@ -1031,7 +1031,7 @@ static void obd_sysfs_release(struct kobject *kobj) > }; > > int lprocfs_obd_setup(struct obd_device *obd, struct lprocfs_vars *list, > - struct attribute_group *attrs) > + const struct attribute_group *attrs) > { > int rc = 0; >