Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361AbdGQHmZ (ORCPT ); Mon, 17 Jul 2017 03:42:25 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36646 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbdGQHmY (ORCPT ); Mon, 17 Jul 2017 03:42:24 -0400 Subject: Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures. To: oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1500270540-5928-1-git-send-email-arvind.yadav.cs@gmail.com> <1500270540-5928-4-git-send-email-arvind.yadav.cs@gmail.com> Cc: john.hammond@intel.com, dmitry.eremin@intel.com, fan.yong@intel.com From: Arvind Yadav Message-ID: <97f530fa-1a6a-b129-4190-2e96f2f0b81f@gmail.com> Date: Mon, 17 Jul 2017 13:11:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1500270540-5928-4-git-send-email-arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 28 Sorry for noise. Please ignore this. ~arvind On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work > with const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > index 9f5e829..eb88bd9 100644 > --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > @@ -405,7 +405,7 @@ static int obd_device_list_open(struct inode *inode, struct file *file) > struct kobject *lustre_kobj; > EXPORT_SYMBOL_GPL(lustre_kobj); > > -static struct attribute_group lustre_attr_group = { > +static const struct attribute_group lustre_attr_group = { > .attrs = lustre_attrs, > }; >