Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751313AbdGQIXj (ORCPT ); Mon, 17 Jul 2017 04:23:39 -0400 Received: from mail.skyhub.de ([5.9.137.197]:51762 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbdGQIXi (ORCPT ); Mon, 17 Jul 2017 04:23:38 -0400 Date: Mon, 17 Jul 2017 10:23:24 +0200 From: Borislav Petkov To: Arvind Yadav Cc: mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] edac: constify attribute_group structures. Message-ID: <20170717082324.GA23129@nazgul.tnic> References: <776cb8265509054abd01b0b551624cc0da3b88e7.1499078335.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <776cb8265509054abd01b0b551624cc0da3b88e7.1499078335.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 30 On Mon, Jul 03, 2017 at 04:09:33PM +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 6026 2541 12 8579 2183 drivers/edac/edac_mc_sysfs.o > > File size After adding 'const': > text data bss dec hex filename > 6090 2477 12 8579 2183 drivers/edac/edac_mc_sysfs.o What is that before/after thing supposed to tell me exactly? > Signed-off-by: Arvind Yadav > --- > drivers/edac/edac_mc_sysfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Anyway, I've merged your two EDAC patches into one and applied it. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --