Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987AbdGQKl0 (ORCPT ); Mon, 17 Jul 2017 06:41:26 -0400 Received: from mga11.intel.com ([192.55.52.93]:4878 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbdGQKlX (ORCPT ); Mon, 17 Jul 2017 06:41:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,374,1496127600"; d="scan'208";a="1173432630" Message-ID: <1500288080.29303.38.camel@linux.intel.com> Subject: Re: [PATCH 1/2] thermal: int340x: constify attribute_group structures. From: Andy Shevchenko To: Arvind Yadav , rui.zhang@intel.com, edubezval@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 17 Jul 2017 13:41:20 +0300 In-Reply-To: <3b42983a016cbb0d1fb3b6bab625b78abf843474.1500287619.git.arvind.yadav.cs@gmail.com> References: <3b42983a016cbb0d1fb3b6bab625b78abf843474.1500287619.git.arvind.yadav.cs@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1464 Lines: 44 On Mon, 2017-07-17 at 16:04 +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work > with const attribute_group. So mark the non-const structs as const. > I hope you did compile test it. > File size before: >    text    data     bss     dec     hex > filename >    1687     592       0    2279     8e7 > int3400_thermal.o > > File size After adding 'const': >    text    data     bss     dec     hex > filename >    1751     528       0    2279     8e7 > int3400_thermal.o > > Signed-off-by: Arvind Yadav > --- >  drivers/thermal/int340x_thermal/int3400_thermal.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/int340x_thermal/int3400_thermal.c > b/drivers/thermal/int340x_thermal/int3400_thermal.c > index a9ec94e..b2ffbed 100644 > --- a/drivers/thermal/int340x_thermal/int3400_thermal.c > +++ b/drivers/thermal/int340x_thermal/int3400_thermal.c > @@ -104,7 +104,7 @@ static ssize_t current_uuid_store(struct device > *dev, >   NULL >  }; >   > -static struct attribute_group uuid_attribute_group = { > +static const struct attribute_group uuid_attribute_group = { >   .attrs = uuid_attrs, >   .name = "uuids" >  }; -- Andy Shevchenko Intel Finland Oy