Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbdGQLDa (ORCPT ); Mon, 17 Jul 2017 07:03:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44594 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbdGQLD2 (ORCPT ); Mon, 17 Jul 2017 07:03:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8FCBC4E334 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8FCBC4E334 Message-ID: <1500289405.12570.5.camel@redhat.com> Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation From: Gerd Hoffmann To: Kirti Wankhede , "Zhang, Tina" , "Tian, Kevin" , "linux-kernel@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "alex.williamson@redhat.com" , "zhenyuw@linux.intel.com" , "chris@chris-wilson.co.uk" , "Lv, Zhiyuan" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" Date: Mon, 17 Jul 2017 13:03:25 +0200 In-Reply-To: <100da721-b765-ed65-7b4b-86e737e2889d@nvidia.com> References: <1499293795-6265-1-git-send-email-tina.zhang@intel.com> <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com> <1499753648.8257.3.camel@redhat.com> <20170711091236.run4zirxmr34kazb@phenom.ffwll.local> <237F54289DF84E4997F34151298ABEBC7C57BF86@SHSMSX101.ccr.corp.intel.com> <20170712074038.izr6ureby4vwtq27@phenom.ffwll.local> <237F54289DF84E4997F34151298ABEBC7C57E3FF@SHSMSX101.ccr.corp.intel.com> <2c07d8ee-d974-33ec-2cf4-b320fc466c88@nvidia.com> <1500033939.28252.16.camel@redhat.com> <100da721-b765-ed65-7b4b-86e737e2889d@nvidia.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 17 Jul 2017 11:03:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 529 Lines: 18 Hi, > No need of flag here. If vGPU driver is not loaded in the guest, > there > is no surface being managed by vGPU, in that case this size will be > zero. Ok, we certainly have the same situation with intel. When the guest driver is not loaded (yet) there is no valid surface. We should cleanly define what the ioctl should do in that case, so all drivers behave the same way. I'd suggest that all fields defining the surface (drm_format, width, height, stride, size) should be set to zero in that case. cheers, Gerd