Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbdGQMGJ (ORCPT ); Mon, 17 Jul 2017 08:06:09 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37670 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbdGQMFE (ORCPT ); Mon, 17 Jul 2017 08:05:04 -0400 Date: Mon, 17 Jul 2017 13:05:00 +0100 From: Lee Jones To: "Gustavo A. R. Silva" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: max8925-i2c: remove unnecessary static in max8925_probe() Message-ID: <20170717120500.hekp3x7psqf44koc@dell> References: <20170704190633.GA20394@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170704190633.GA20394@embeddedgus> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1401 Lines: 57 On Tue, 04 Jul 2017, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variable _chip_. > Such variable is initialized before being used, > on every execution path throughout the function. > The static has no benefit and, removing it reduces > the code size. > > This issue was detected using Coccinelle and the following semantic patch: > > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > > In the following log you can see the difference in the code size and, > also a significant difference in the bss segment. This log is the output > of the size command, before and after the code change: > > before: > text data bss dec hex filename > 4188 1336 128 5652 1614 drivers/mfd/max8925-i2c.o > > after: > text data bss dec hex filename > 4135 1280 64 5479 1567 drivers/mfd/max8925-i2c.o > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/mfd/max8925-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog