Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbdGQMVu (ORCPT ); Mon, 17 Jul 2017 08:21:50 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38311 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdGQMVs (ORCPT ); Mon, 17 Jul 2017 08:21:48 -0400 Date: Mon, 17 Jul 2017 13:21:44 +0100 From: Lee Jones To: Arvind Yadav Cc: thierry.reding@gmail.com, daniel.thompson@linaro.org, jingoohan1@gmail.com, b.zolnierkie@samsung.com, linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: pwm_bl: make of_device_ids const Message-ID: <20170717122144.hw72eeqiobfdkhtv@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 32 On Tue, 20 Jun 2017, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/video/backlight/pwm_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index 002f1ce..9bd1768 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev, > return 0; > } > > -static struct of_device_id pwm_backlight_of_match[] = { > +static const struct of_device_id pwm_backlight_of_match[] = { > { .compatible = "pwm-backlight" }, > { } > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog