Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751319AbdGQNLM (ORCPT ); Mon, 17 Jul 2017 09:11:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:42540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289AbdGQNLL (ORCPT ); Mon, 17 Jul 2017 09:11:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2F9122BD9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 17 Jul 2017 10:11:08 -0300 From: Arnaldo Carvalho de Melo To: Ravi Bangoria Cc: kjlx@templeofstupid.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf probe: Fix build failure for get_target_map() Message-ID: <20170717131108.GC10517@kernel.org> References: <1499305693-1599-4-git-send-email-kjlx@templeofstupid.com> <1500287542-6219-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500287542-6219-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1468 Lines: 38 Em Mon, Jul 17, 2017 at 04:02:22PM +0530, Ravi Bangoria escreveu: > Commit 801bc8193463 ("perf probe: Allow placing uprobes in > alternate namespaces.") is causing a build failure on powerpc: > > error: incompatible type for argument 2 of 'get_target_map' > map = get_target_map(pev->target, pev->uprobes); > ^~~ > > Fix it by changing parameters of get_target_map(). Thanks, since this hasn't made it to Ingo I'll fold this into the patch where the problem was introduced, adding credits to you, leaving a Link to this message, so that we don't lose bisection in this area on powerpc. - Arnaldo > Fixes: 801bc8193463 ("perf probe: Allow placing uprobes in alternate namespaces.") > Signed-off-by: Ravi Bangoria > --- > tools/perf/arch/powerpc/util/sym-handling.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/arch/powerpc/util/sym-handling.c b/tools/perf/arch/powerpc/util/sym-handling.c > index bf9a259..9c4e23d 100644 > --- a/tools/perf/arch/powerpc/util/sym-handling.c > +++ b/tools/perf/arch/powerpc/util/sym-handling.c > @@ -126,7 +126,7 @@ void arch__post_process_probe_trace_events(struct perf_probe_event *pev, > struct rb_node *tmp; > int i = 0; > > - map = get_target_map(pev->target, pev->uprobes); > + map = get_target_map(pev->target, pev->nsi, pev->uprobes); > if (!map || map__load(map) < 0) > return; > > -- > 2.1.4