Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751397AbdGQNi0 (ORCPT ); Mon, 17 Jul 2017 09:38:26 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:57730 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbdGQNiY (ORCPT ); Mon, 17 Jul 2017 09:38:24 -0400 Date: Mon, 17 Jul 2017 15:38:11 +0200 From: Andrew Lunn To: sean.wang@mediatek.com Cc: john@phrozen.org, davem@davemloft.net, nbd@openwrt.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v2 1/4] dt-bindings: net: mediatek: add support for MediaTek MT7623 and MT7622 SoC Message-ID: <20170717133811.GA30392@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 32 On Mon, Jul 17, 2017 at 06:06:22PM +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > The patch adds the supplements in the dt-binding document for MediaTek > MT7622 SoC with extra SGMII system controller and relevant clock consumers > listed as the requirements for those SoCs equipped with the SGMII circuit. > Also, add the missing binding information for MT7623 SoC here which relies > on the fallback binding of MT2701. > > Signed-off-by: Sean Wang > --- > Documentation/devicetree/bindings/net/mediatek-net.txt | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt > index c7194e8..1d1168b 100644 > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt > @@ -7,24 +7,30 @@ have dual GMAC each represented by a child node.. > * Ethernet controller node > > Required properties: > -- compatible: Should be "mediatek,mt2701-eth" > +- compatible: Should be > + "mediatek,mt2701-eth": for MT2701 SoC > + "mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC Hi Sean We appear to have "mediatek,mt2701-eth" twice. Andrew