Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbdGQPxM (ORCPT ); Mon, 17 Jul 2017 11:53:12 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32855 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbdGQPxL (ORCPT ); Mon, 17 Jul 2017 11:53:11 -0400 Date: Mon, 17 Jul 2017 17:53:06 +0200 From: Daniel Vetter To: Brian Norris Cc: Sean Paul , David Airlie , Daniel Vetter , Jani Nikula , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/vgem: add compat_ioctl support Message-ID: <20170717155306.5tfzzvsu6w7pjzdu@phenom.ffwll.local> Mail-Followup-To: Brian Norris , Sean Paul , David Airlie , Daniel Vetter , Jani Nikula , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20170715031212.108695-1-briannorris@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170715031212.108695-1-briannorris@chromium.org> X-Operating-System: Linux phenom 4.11.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 38 On Fri, Jul 14, 2017 at 08:12:12PM -0700, Brian Norris wrote: > DRM drivers should supply a compat version if they're going to provide > an ioctl implementation at all. This can confuse 32-bit user space on a > 64-bit system. > > Signed-off-by: Brian Norris Thanks, applied. -Daniel > --- > drivers/gpu/drm/vgem/vgem_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c > index 9fee38a942c4..3835656e2baf 100644 > --- a/drivers/gpu/drm/vgem/vgem_drv.c > +++ b/drivers/gpu/drm/vgem/vgem_drv.c > @@ -220,6 +220,7 @@ static const struct file_operations vgem_driver_fops = { > .poll = drm_poll, > .read = drm_read, > .unlocked_ioctl = drm_ioctl, > + .compat_ioctl = drm_compat_ioctl, > .release = drm_release, > }; > > -- > 2.13.2.932.g7449e964c-goog > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch