Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdGQQhJ (ORCPT ); Mon, 17 Jul 2017 12:37:09 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:32946 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdGQQhH (ORCPT ); Mon, 17 Jul 2017 12:37:07 -0400 Date: Mon, 17 Jul 2017 09:37:02 -0700 From: Benson Leung To: Enric Balletbo Serra Cc: Gwendal Grignou , Enric Balletbo i Serra , Jonathan Cameron , Lee Jones , Benson Leung , Javier Martinez Canillas , Guenter Roeck , Linux Kernel , linux-iio@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev. Message-ID: <20170717163702.GA149214@decatoncale.mtv.corp.google.com> References: <20170712101309.6045-1-enric.balletbo@collabora.com> <20170712101309.6045-2-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1906 Lines: 58 --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Enric, On Mon, Jul 17, 2017 at 12:30:30PM +0200, Enric Balletbo Serra wrote: > Hi Gwendal, >=20 > Interesting I didn't know that. So are you saying that this patch will > break support for devices like Pixel 2? I tested the patches on > various devices but not on Pixel 2 so could be. This would affect any systems where we have chained ECs. Samus (Chromebook Pixel 2015) has its PD EC hooked up in this way. Practically speaking, that would mean that the cros_usbpd-charger power supply driver may not work correctly. I don't think we expect any other systems to have this configuration, but the first one we shipped did, so we will have to support it. Thanks, Benson --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJZbOeuAAoJEB8J9XsKL+ZYPUUP/jl0EUnsXvp5RTP13/o8a0dK ZlHGscqp6Jj2HiokkAISVoMkumrToaNLkfCtsFGONoeF4ZrbifrmTRzITwYD0Uqn F3NOKPM4sVyNgsodDmY4sDAGf6YjUdDZNF/2qVBM/L3ZhGMerr2qC7JsYoSwUMjp CQEA4XNReWpscg0FFdcDsmxpHbJqZ3AeWYbCvbV0ylkCIZZG9HwtkPagO+ihaeTj q5KTL+lpmDhHpUqeQtdubAHrKhs9ZPWML67p4YIdnn6d7q5NR+QaqNpBleNBpAel J/kzKros3xLbe5UnbJ3KTtdK7OIAmyJJf6On78glwDI8m6qX1NwfcPIyKZofcymc il8Iyec1c0b54isZrl4wA4nTC33KzihATkAhqZBZPMwRn9kRIPnDHCag9ZQWfpME f36aV8pKPrgxnCrRA4WKpLOaUuHS4ks9aoVKa/6fvA7D0wnV7o2L8xQMtKL/QgWm /fCj34m59LiQ3XyNAlWaIuwiDk6UGHAZQRF9VJS8VTjWzmN5tEN63pOotCtFAVoY kM9S42mihlhmsGin55NcTTb5DixwPvJQVV5Fi+5dK6Kpa+xwQy6g0n9sNx/4cyX+ KcrMOOUeDzueDOlb/Xth7Vl87qqZbhVdv1XIW4mVw7tnoiITlXjC39Q5GmDvdB4K rTYDExJIt5dn4Bq/zUrL =KeCE -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--