Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751387AbdGQQuc (ORCPT ); Mon, 17 Jul 2017 12:50:32 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:35749 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbdGQQua (ORCPT ); Mon, 17 Jul 2017 12:50:30 -0400 Subject: Re: [RFC PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER To: Adrian Hunter , Ulf Hansson Cc: "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" References: <20170628133504.17422-1-srinivas.kandagatla@linaro.org> <20170628133504.17422-2-srinivas.kandagatla@linaro.org> <2440f065-ccd4-4575-4443-2acd1c23d6c4@intel.com> From: Srinivas Kandagatla Message-ID: <08df140f-0630-f7ce-3e1a-9837f24e1796@linaro.org> Date: Mon, 17 Jul 2017 17:50:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <2440f065-ccd4-4575-4443-2acd1c23d6c4@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 611 Lines: 17 On 17/07/17 13:47, Adrian Hunter wrote: >> This change seems like a reasonable justification for adding a new >> SDHCI quirk, even if we in general wants to avoid that. >> >> Adrian? > If we add a quirk for every register we end up with a very ugly version of > CONFIG_MMC_SDHCI_IO_ACCESSORS. So CONFIG_MMC_SDHCI_IO_ACCESSORS is a better > option. Another possibility is to add a member to struct sdhci_host, > initialized to SDHCI_DEFAULT_BOUNDARY_ARG, and write that. Drivers could > then change the value if necessary. Second option seems to be better one. I will give it a try and see! thanks, srini