Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbdGQRoC (ORCPT ); Mon, 17 Jul 2017 13:44:02 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58092 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbdGQRoB (ORCPT ); Mon, 17 Jul 2017 13:44:01 -0400 Date: Mon, 17 Jul 2017 19:43:57 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 06/12] net: dsa: mv88e6xxx: add number of Global 2 IRQs Message-ID: <20170717174357.GI30392@lunn.ch> References: <20170717170346.19555-1-vivien.didelot@savoirfairelinux.com> <20170717170346.19555-7-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170717170346.19555-7-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 538 Lines: 15 On Mon, Jul 17, 2017 at 01:03:40PM -0400, Vivien Didelot wrote: > Similarly to g1_irqs, add a g2_irqs member to the info structure to > indicates the presence of the Global 2 Interrupt Source and Mask > registers. > > At the same time, provide helpers and document the registers since they > differ a bit between 88E6352 and 88E6390 families. > > This allows us to get rid of the MV88E6XXX_FLAG_G2_INT flag. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew