Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751411AbdGQRpD convert rfc822-to-8bit (ORCPT ); Mon, 17 Jul 2017 13:45:03 -0400 Received: from mga14.intel.com ([192.55.52.115]:31667 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbdGQRpC (ORCPT ); Mon, 17 Jul 2017 13:45:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,375,1496127600"; d="scan'208";a="879791840" From: "Dilger, Andreas" To: Craig Inches CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue Thread-Topic: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue Thread-Index: AQHS+u3A6B1/WVR0jUmznvzE6odxSKJYyFQA Date: Mon, 17 Jul 2017 17:44:59 +0000 Message-ID: References: <774a2f25b839305f100e7fa99ebf835fb2ab7d44.1499849566.git.Craig@craiginches.com> In-Reply-To: <774a2f25b839305f100e7fa99ebf835fb2ab7d44.1499849566.git.Craig@craiginches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.19.246] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 38 On Jul 12, 2017, at 03:03, Craig Inches wrote: > > This fixes a block statement which didnt end with */ > > Signed-off-by: Craig Inches > --- > drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include/linux/lnet/socklnd.h > index dd5bc0e46560..a1ae66ede7a8 100644 > --- a/drivers/staging/lustre/include/linux/lnet/socklnd.h > +++ b/drivers/staging/lustre/include/linux/lnet/socklnd.h > @@ -76,7 +76,8 @@ struct ksock_msg { > __u64 ksm_zc_cookies[2]; /* Zero-Copy request/ACK cookie */ > union { > struct ksock_lnet_msg lnetmsg; /* lnet message, it's empty if > - * it's NOOP */ > + * it's NOOP > + */ Rather than making the multi-line comments even more space consuming (I'm not a big fan of "*/ must be on a line by itself" since it wastes a lot of vertical space), I'd prefer to just shorten the comment, if possible, like: struct ksock_lnet_msg lnetmsg; /* lnet message, empty if NOOP */ Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation